Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Mono] Add SIMD intrinsic for Vector64/128 comparisons (#65128)" #66088

Conversation

simonrozsival
Copy link
Member

@simonrozsival simonrozsival commented Mar 2, 2022

This PR reverts #65128 in an attempt to fix #66083

@vargaz
Copy link
Contributor

vargaz commented Mar 2, 2022

This doesn't seem to solve the problem.

@fanyang-mono fanyang-mono added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 2, 2022
@thaystg
Copy link
Member

thaystg commented Mar 2, 2022

This didn't cause the problem on CI, I'll close the PR.

@thaystg
Copy link
Member

thaystg commented Mar 4, 2022

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg
Copy link
Member

thaystg commented Mar 4, 2022

It looks like that reverting this the timeout issue is gone:

image

@vargaz
Copy link
Contributor

vargaz commented Mar 5, 2022

Note that the lane still takes 2h52m (172m), and the timeout is 3h20m (200m), so even a 10-15% increase in total AOT time would lead to a timeout.

@fanyang-mono fanyang-mono removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 7, 2022
@fanyang-mono
Copy link
Member

The step of Send tests to Helix did came down to ~10mins from ~1h. I would consider this PR did resolve the issue. This lane usually takes 2h30mins and more. We could let this PR run another time to get another data point.

@simonrozsival
Copy link
Member Author

@fanyang-mono I'll re-run the tests

@simonrozsival
Copy link
Member Author

The llvm aot lanes are now OK:

image

but so are the same lanes in the rolling build on main:

image

Now it's Mono minijit Pri0 Runtime Tests Run OSX x64 release and Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release that are timing out (both this PR and the rolling build).

@fanyang-mono
Copy link
Member

Since the llvmaot and llvmfullaot lanes are back to normal on main. This PR should be closed. The long Send tests to Helix step that I observed before could be infrastructure hiccups.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TIME OUT - Mono llvmfullaot Pri0 Runtime Tests Run Linux arm64 release
4 participants