Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DllImportGenerator project to LibraryImportGenerator #66029

Merged

Conversation

elinor-fung
Copy link
Member

Rename build/organization-related parts of DllImportGenerator to LibraryImportGenerator to align with the LibraryImportAttribute name. This renames:

  • Project and .props files
  • Directories under src/System.Runtime.InteropServices/gen and docs
  • Build properties

This change does not update the namespace/classes/files or the attribute itself - those will come separately.

Commits are:

  • Renaming the directories and projects
  • Renaming the MSBuild properties
  • Running slngen

@elinor-fung elinor-fung added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Mar 1, 2022
@ghost
Copy link

ghost commented Mar 1, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Rename build/organization-related parts of DllImportGenerator to LibraryImportGenerator to align with the LibraryImportAttribute name. This renames:

  • Project and .props files
  • Directories under src/System.Runtime.InteropServices/gen and docs
  • Build properties

This change does not update the namespace/classes/files or the attribute itself - those will come separately.

Commits are:

  • Renaming the directories and projects
  • Renaming the MSBuild properties
  • Running slngen
Author: elinor-fung
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: -

@ghost ghost assigned elinor-fung Mar 1, 2022
@elinor-fung elinor-fung added this to the 7.0.0 milestone Mar 1, 2022
@elinor-fung elinor-fung force-pushed the rename-libraryImportGeneratorProj branch 2 times, most recently from a388692 to 832147e Compare March 2, 2022 03:53
@elinor-fung elinor-fung force-pushed the rename-libraryImportGeneratorProj branch 5 times, most recently from d97a439 to da9b487 Compare March 3, 2022 19:48
@elinor-fung elinor-fung force-pushed the rename-libraryImportGeneratorProj branch from da9b487 to 6405ecb Compare March 3, 2022 20:36
@elinor-fung elinor-fung merged commit a063583 into dotnet:main Mar 4, 2022
@elinor-fung elinor-fung deleted the rename-libraryImportGeneratorProj branch March 4, 2022 06:17
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants