Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update p/invoke source generator errors to use SYSLIB prefix #65983

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Mar 1, 2022

Use the established SYSLIB prefix convention, since the p/invoke source generator will be part of libraries.

@elinor-fung elinor-fung added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Mar 1, 2022
@elinor-fung elinor-fung added this to the 7.0.0 milestone Mar 1, 2022
@ghost ghost assigned elinor-fung Mar 1, 2022
@ghost
Copy link

ghost commented Mar 1, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: elinor-fung
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: 7.0.0

@elinor-fung
Copy link
Member Author

System.IO.Tests failure is #65791
System.Runtime.InteropServices.Tests.GetEndComSlotTests.GetEndComSlot_Windows_ReturnsExpected failures are unrelated - from #65926

@elinor-fung elinor-fung merged commit a7a4ed9 into dotnet:main Mar 1, 2022
@elinor-fung elinor-fung deleted the syslibPrefix branch March 1, 2022 22:24
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants