Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenAPI usage and code clean-up #65887

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Update GenAPI usage and code clean-up #65887

merged 5 commits into from
Feb 28, 2022

Conversation

ViktorHofer
Copy link
Member

dotnet/arcade@e44123d switched GenAPI to run in-proc as an msbuild task. Because of that, the usage is slightly different when additional parameters are passed in to GenAPI.

Also moving the code into the resolvecontract.targets file which contains contract related logic.

@ghost
Copy link

ghost commented Feb 25, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet/arcade@e44123d switched GenAPI to run in-proc as an msbuild task. Because of that, the usage is slightly different when additional parameters are passed in to GenAPI.

Also moving the code into the resolvecontract.targets file which contains contract related logic.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 26, 2022

Can someone please approve? :) This needs to go in before the next dependency update: #65843.

@ViktorHofer ViktorHofer merged commit 7667e41 into main Feb 28, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch February 28, 2022 16:35
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants