-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark architecture-specific tests with ConditionalFact attributes #65862
Conversation
This change adds initial provisions for platform detection similar to library logic to CoreCLRTestLibrary and marks a few architecture-conditional tests with ConditionalFact attributes. While I must admit I'm not happy about the IL representation of the ConditionalFact attributes, it's technically using the same representation as the library tests do and it only affects a handful of tests. During consolidation of the remaining tests we'll continue working on an easier solution even though it may require diverging further away from Xunit. I'm not yet removing the CLRTestTargetUnsupported clauses from the corresponding project files, that can only be done after switching these tests over to use the merged wrappers (my next change) as the legacy XUnit wrapper generator (in particular the test execution script generator) relies on those properties. Thanks Tomas
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis change adds initial provisions for platform detection similar While I must admit I'm not happy about the IL representation of I'm not yet removing the CLRTestTargetUnsupported clauses from Thanks Tomas /cc @dotnet/jit-contrib
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis change adds initial provisions for platform detection similar While I must admit I'm not happy about the IL representation of I'm not yet removing the CLRTestTargetUnsupported clauses from Thanks Tomas /cc @dotnet/jit-contrib
|
using System; | ||
using System.Runtime.InteropServices; | ||
|
||
public static class PlatformDetection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this in the TestLibrary
namespace instead of the global namespace? I know you'd have to go back and manually update all of the custom attributes, so I understand if you'd rather not do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I can easily do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what I understand about this, it LGTM. I'll let @jkoritzinsky make the final call.
@trylek Introducing |
Adding a link to timeout caused in aot lanes due to this change : #66083 |
This change adds initial provisions for platform detection similar
to library logic to CoreCLRTestLibrary and marks a few
architecture-conditional tests with ConditionalFact attributes.
While I must admit I'm not happy about the IL representation of
the ConditionalFact attributes, it's technically using the same
representation as the library tests do and it only affects a handful
of tests. During consolidation of the remaining tests we'll
continue working on an easier solution even though it may require
diverging further away from Xunit.
I'm not yet removing the CLRTestTargetUnsupported clauses from
the corresponding project files, that can only be done after
switching these tests over to use the merged wrappers (my next
change) as the legacy XUnit wrapper generator (in particular the
test execution script generator) relies on those properties.
Thanks
Tomas
/cc @dotnet/jit-contrib