Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF][MAUI]dotnet-podcast startup time and size measurements #65813

Merged
merged 44 commits into from
Mar 14, 2022
Merged

[PERF][MAUI]dotnet-podcast startup time and size measurements #65813

merged 44 commits into from
Mar 14, 2022

Conversation

naricc
Copy link
Contributor

@naricc naricc commented Feb 23, 2022 •
edited
Loading

Changes to run the dotnet-podcast app in both CI, for both size and start up time.

@ghost ghost assigned naricc Feb 23, 2022
@ghost
Copy link

ghost commented Feb 23, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a draft PR for testing CI to measure startup and size for the dotnet-podcast app. I don't expect that it actually works yet.

Author: naricc
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@naricc naricc mentioned this pull request Feb 23, 2022
Closed
@naricc naricc force-pushed the naricc/maui-dotnet-podcast branch from 0093845 to b6cbbd8 Compare February 24, 2022 20:28
@runfoapp runfoapp bot mentioned this pull request Feb 25, 2022
Closed
@naricc naricc force-pushed the naricc/maui-dotnet-podcast branch from c0b8836 to feaf92e Compare February 28, 2022 19:39
@naricc
Copy link
Contributor Author

naricc commented Mar 4, 2022 •
edited
Loading

I have this building the dotnet-podcast app in CI, but it is not yet running. I can't see the error because of some issue with retrieving logs from helix. I am blocked on this until that is resolved.

Here is the issue: dotnet/arcade#8554

@runfoapp runfoapp bot mentioned this pull request Mar 4, 2022
Closed
@naricc naricc force-pushed the naricc/maui-dotnet-podcast branch from c309c88 to 01214f9 Compare March 8, 2022 23:38
@naricc
Copy link
Contributor Author

naricc commented Mar 9, 2022

I needed to make additional changes to the podcast app, because it was crashing on startup. I am now attempting to see if it will run in CI.

@naricc naricc force-pushed the naricc/maui-dotnet-podcast branch from 3f610cc to dbf3bdd Compare March 11, 2022 20:22
@naricc naricc force-pushed the naricc/maui-dotnet-podcast branch from dbf3bdd to d837f99 Compare March 11, 2022 20:54
@naricc naricc marked this pull request as ready for review March 14, 2022 02:45
@naricc naricc requested a review from LoopedBard3 March 14, 2022 02:46
@naricc naricc changed the title [DRAFT][PERF][MAUI]dotnet-podcast startup time and size measurements [PERF][MAUI]dotnet-podcast startup time and size measurements Mar 14, 2022
LoopedBard3
LoopedBard3 reviewed Mar 14, 2022
View reviewed changes
eng/testing/performance/android_scenarios.proj Show resolved Hide resolved
eng/pipelines/coreclr/templates/build-perf-maui-apps.yml
- script: |
set -x
pwd
git clone https://github.com/naricc/dotnet-podcasts.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about what to do here going forward.

eng/pipelines/coreclr/templates/build-perf-maui-apps.yml Outdated Show resolved Hide resolved
@LoopedBard3 LoopedBard3 self-requested a review March 14, 2022 23:20
LoopedBard3
LoopedBard3 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naricc
Copy link
Contributor Author

naricc commented Mar 14, 2022

There are a few runtime test failures, but they appear to be spurious. We made no runtime changes, an didn't even touch the related templates. So I am merging this.

@naricc naricc merged commit e74c3e8 into dotnet:main Mar 14, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@radekdoulik
[PERF][MAUI]dotnet-podcast startup time and size measurements (dotnet…
cf4f88a 
…#65813)

Enable size and startup time monitoring for MAUI dotnet-podcast app on Android.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

Assignees

@naricc naricc

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naricc @LoopedBard3