Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Queryable-to-Enumerable overload mapping logic #65569

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Fix Queryable-to-Enumerable overload mapping logic #65569

merged 4 commits into from
Feb 24, 2022

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Feb 18, 2022 •
edited
Loading

Fix #65419.

Should be considered for .NET 6 servicing.

@ghost ghost assigned eiriktsarpalis Feb 18, 2022
@ghost
Copy link

ghost commented Feb 18, 2022

Tagging subscribers to this area: @dotnet/area-system-linq
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #65419

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Linq
Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Feb 18, 2022
eerhardt
eerhardt approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thinking of any better approaches here, so if this approach works and is the best approach you can think of, LGTM.

src/libraries/System.Linq.Queryable/src/System/Linq/EnumerableRewriter.cs Show resolved Hide resolved
src/libraries/System.Linq.Queryable/src/System/Linq/EnumerableRewriter.cs Outdated Show resolved Hide resolved
@runfoapp runfoapp bot mentioned this pull request Feb 23, 2022
Closed
@eiriktsarpalis eiriktsarpalis merged commit 96cd39d into dotnet:main Feb 24, 2022
@eiriktsarpalis
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1894781449

@github-actions github-actions bot mentioned this pull request Feb 24, 2022
Merged
@eiriktsarpalis eiriktsarpalis deleted the fix-queryable-overloads branch February 24, 2022 20:39
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@krwq krwq Awaiting requested review from krwq

@layomia layomia Awaiting requested review from layomia

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Linq
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

The value returned by AsQueryable().FirstOrDefault is different between Net5.0 and Net6.0
2 participants
@eiriktsarpalis @eerhardt