-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic Enum
methods where possible.
#64850
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsThis PR updates all non-test projects that exclusively target .NET 6 and above to use the generic
|
.../System.ComponentModel.TypeConverter/src/System/ComponentModel/ToolboxItemFilterAttribute.cs
Outdated
Show resolved
Hide resolved
…omponentModel/ToolboxItemFilterAttribute.cs Co-authored-by: Günther Foidl <[email protected]>
src/libraries/System.Private.Xml/src/System/Xml/Xsl/IlGen/OptimizerPatterns.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
@steveisok, the runtime-staging legs keep timing out on this PR. Is there a known issue here? Is it possible this PR is causing it? |
I'd update the branch to the latest main. The helix queue being used is different. |
Thanks. Shouldn't that have happened automatically when I closed and re-opened the PR? Or does rebasing on the latest main no longer happen automatically? Given that these are stale and everything else passed and there's nothing in the PR that should be mono-specific or iOS-specific, I'm just going to merge. |
That was why you closed and reopened it twice. 😅 Didn't know that was ever a thing. |
@teo-tsirpanis it's easier than pushing a blank change -- I even do it on my phone! The other option is an |
When Stephen said about "rebasing on the latest main" my first thought was that it would rebase my fork's branch and was confused, but turns out he meant it would run CI again with my changes incorporated to the latest main, and makes more sense. |
Got it, yes, I believe each time that validation runs, it behind the scenes rebases on the latest HEAD before it builds. |
Enum
methods when possible.Enum
methods where possible.
This PR updates all non-test projects that exclusively target .NET 6 and above to use the generic
Enum
methods (#2364), reducing boxing and (perhaps?) making the code more AOT-friendly.