Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for Assertion failed '(op3Reg != targetReg) || (op1Reg == targetReg)' during 'Generate code' #62343

Closed
wants to merge 1 commit into from

Conversation

weilinwa
Copy link
Contributor

@weilinwa weilinwa commented Dec 3, 2021

This is for #62267.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2021
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

This is for #62267.

Author: weilinwa
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@weilinwa
Copy link
Contributor Author

weilinwa commented Dec 3, 2021

@kunalspathak, please take a look at this change. It should fix the assertion failure. Thanks!

@kunalspathak
Copy link
Member

/azp run runtime-coreclr superpmi-replay

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tannergooding
Copy link
Member

I missed that this had been put up and also put up my own fix: #62382

My variant is basically the same but explicitly calls out the need to keep lsra and codegen in sync here and fixes a case in LSRA where a wrong swap was happening.

@kunalspathak
Copy link
Member

Thank you @weilinwa for working on this. Since we will be merging #62382 , we can close this PR.

@weilinwa weilinwa closed this Dec 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants