Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trees generated for vtable calls #62177

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Conversation

MichalStrehovsky
Copy link
Member

Fixes issue observed in dotnet/runtimelab#1128 (comment) - the trees generate additions of TYP_I_IMPL with TYP_INT and that confuses things down the line.

Fixes issue observed in dotnet/runtimelab#1128 (comment) - the trees generate additions of `TYP_I_IMPL` with `TYP_INT` and that confuses things down the line.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2021
@ghost
Copy link

ghost commented Nov 30, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes issue observed in dotnet/runtimelab#1128 (comment) - the trees generate additions of TYP_I_IMPL with TYP_INT and that confuses things down the line.

Author: MichalStrehovsky
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member

There is also an occurrence here:

op1 = gtNewOperNode(GT_ADD, op1->TypeGet(), op1,
new (this, GT_CNS_INT) GenTreeIntCon(TYP_INT, pFieldInfo->offset, fs));

Do you mind giving it the same treatment?

@MichalStrehovsky
Copy link
Member Author

Do you mind giving it the same treatment?

Sure, done. Fingers crossed I won't have to fight the formatter again.

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, no diffs according to SPMI jobs.

@jakobbotsch jakobbotsch merged commit 9fae29d into main Dec 1, 2021
@jkotas jkotas deleted the MichalStrehovsky-patch-1 branch December 1, 2021 17:48
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants