Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track a missing place to reset alignment flag from BasicBlock #62163

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Nov 29, 2021

There was a place when we reverse a conditional jump, we were not removing the alignment flag.

Environment:

set COMPlus_TieredCompilation=0
set COMPlus_JitAggressiveInlining=1

Assert failure(PID 10876 [0x00002a7c], Thread: 32880 [0x8070]): Assertion failed 'loopsToProcess == 0' in 'TestClass:Method60(byref,byref,byref,byref,S1_D1_F1,byref,byref,S2,byref,byref,byref,byref):S1:this' during 'Place 'align' instructions' (IL size 528)
    File: D:\git\runtime\src\coreclr\jit\compiler.cpp Line: 5297
    Image: D:\git\runtime\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\CoreRun.exe

There are some occurrences of this issue that Antigen caught over the weekend - https://dev.azure.com/dnceng/public/_build/results?buildId=1488159&view=ms.vss-build-web.run-extensions-tab

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 29, 2021
@ghost
Copy link

ghost commented Nov 29, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

There was a place when we reverse a conditional jump, we were not removing the alignment flag.

Environment:

set COMPlus_TieredCompilation=0
set COMPlus_JitAggressiveInlining=1

Assert failure(PID 10876 [0x00002a7c], Thread: 32880 [0x8070]): Assertion failed 'loopsToProcess == 0' in 'TestClass:Method60(byref,byref,byref,byref,S1_D1_F1,byref,byref,S2,byref,byref,byref,byref):S1:this' during 'Place 'align' instructions' (IL size 528)
    File: D:\git\runtime\src\coreclr\jit\compiler.cpp Line: 5297
    Image: D:\git\runtime\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\CoreRun.exe
Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib @BruceForstall

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

btw, the JITDUMP in BasicBlock::unmarkLoopAlign() looks like it needs a trailing \n

@kunalspathak kunalspathak merged commit 395e7a5 into dotnet:main Dec 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants