-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload dasm files as artifacts for "asmdiffs pipeline" #61700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Nov 16, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue Detailsnull
|
kunalspathak
force-pushed
the
superpmi_asmdiffs
branch
from
November 16, 2021 23:03
71597f3
to
9c91040
Compare
kunalspathak
force-pushed
the
superpmi_asmdiffs
branch
from
November 17, 2021 17:41
873e9be
to
d664d3f
Compare
@dotnet/jit-contrib , @BruceForstall |
kunalspathak
changed the title
Upload dasm files as artifacts
Upload dasm files as artifacts for "asmdiffs pipeline"
Nov 17, 2021
BruceForstall
requested changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just a couple nits
Fixed. |
BruceForstall
approved these changes
Nov 18, 2021
2 tasks
This was referenced Nov 29, 2021
This was referenced Nov 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Dec 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For asmdiffs pipeline, upload the top N improvement/regression .dasm files so the developer can continue the investigation instead of building and producing those .dasm files on their local machine.