Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor File.ReadAllBytes* improvements #61519

Merged
merged 9 commits into from
Nov 17, 2021
Merged

Minor File.ReadAllBytes* improvements #61519

merged 9 commits into from
Nov 17, 2021

Commits on Nov 12, 2021

  1. switch from FileStream to RandomAccess

    @adamsitnik
    adamsitnik committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    eeb5e0b View commit details
    Browse the repository at this point in the history

  2. use Array.MaxLength as a limit for File.ReadAllBytes and fix an edge … 

    …case bug for files: Array.MaxLength < Length < int.MaxValue
    @adamsitnik
    adamsitnik committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    87aaf3d View commit details
    Browse the repository at this point in the history

  3. apply same changes to the async version

    @adamsitnik
    adamsitnik committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    2b6b22b View commit details
    Browse the repository at this point in the history

  4. there is no gain of using FileOptions.SequentialScan, as it requires … 

    …an additional sys call on Unix and every OS is able to recognize the disk access patterns anyway
    @adamsitnik
    adamsitnik committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    39c2621 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Update src/libraries/System.Private.CoreLib/src/System/IO/File.cs 

    Co-authored-by: Dan Moseley <[email protected]>
    @adamsitnik @danmoseley
    adamsitnik and danmoseley authored Nov 15, 2021
    Configuration menu
    Copy the full SHA
    29b6b8d View commit details
    Browse the repository at this point in the history

  2. use SequentialScan on Windows just in case it helps for some configs

    @adamsitnik
    adamsitnik committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    9963347 View commit details
    Browse the repository at this point in the history

  3. use the previous pattern (the code is more complex but also more effi… 

    …cient for edge cases)
    @adamsitnik
    adamsitnik committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    9755a45 View commit details
    Browse the repository at this point in the history

  4. improve test coverage

    @adamsitnik
    adamsitnik committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    9fa8190 View commit details
    Browse the repository at this point in the history

  5. address code review feedback

    @adamsitnik
    adamsitnik committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    2576390 View commit details
    Browse the repository at this point in the history