Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Regex source generator to Microsoft.netcore.app.ref pack #61329

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Nov 8, 2021

See #61321

This is adding the Regex source generator to the netcoreapp ref pack so that it is easier for consumers to use it.

@ghost
Copy link

ghost commented Nov 8, 2021

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #61321

This is adding the Regex source generator to the netcoreapp ref pack so that it is easier for consumers to use it.

Author: joperezr
Assignees: -
Labels:

area-System.Text.RegularExpressions

Milestone: -

@joperezr joperezr requested a review from ericstj November 8, 2021 22:49
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's open an issue to discuss what the convention for inbox generators should be going forward.

@ericstj
Copy link
Member

ericstj commented Nov 9, 2021

Let's open an issue to discuss what the convention for inbox generators should be going forward.

It was my intent for #61321 to also cover deciding on a convention. Maybe you can just leave that open?

@safern
Copy link
Member

safern commented Nov 9, 2021

Maybe you can just leave that open?

Yeah we can do that and rename it to be more general as the title was very specific for Regex.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants