-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Regex source generator to Microsoft.netcore.app.ref pack #61329
Conversation
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue DetailsFixes #61321 This is adding the Regex source generator to the netcoreapp ref pack so that it is easier for consumers to use it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's open an issue to discuss what the convention for inbox generators should be going forward.
It was my intent for #61321 to also cover deciding on a convention. Maybe you can just leave that open? |
Yeah we can do that and rename it to be more general as the title was very specific for Regex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
See #61321
This is adding the Regex source generator to the netcoreapp ref pack so that it is easier for consumers to use it.