[mono][interp] Fix sufficient stack check when using interpreter #60514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icall was only checking the real stack pointer of the thread. The interpreter uses its own execution stack in addition, so we also need to check for overflow there.
BrzVlad
requested review from
imhameed,
lambdageek,
SamMonoRT,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @BrzVlad Issue DetailsThe icall was only checking the real stack pointer of the thread. The interpreter uses its own execution stack in addition, so we also need to check for overflow there. Fixes #38817
|
vargaz
approved these changes
Oct 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icall was only checking the real stack pointer of the thread. The interpreter uses its own execution stack in addition, so we also need to check for overflow there.
Fixes #38817