Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish SuperPMI collect testing #60432

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

BruceForstall
Copy link
Member

  1. Remove testing workaround to upload to "test_collect" special
    JIT-EE version number.
  2. Fix one YML bug
  3. Reduce superpmi replay pipeline timeout

1. Remove testing workaround to upload to "test_collect" special
JIT-EE version number.
2. Fix one YML bug
3. Reduce superpmi replay pipeline timeout
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 14, 2021
@ghost
Copy link

ghost commented Oct 14, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Remove testing workaround to upload to "test_collect" special
    JIT-EE version number.
  2. Fix one YML bug
  3. Reduce superpmi replay pipeline timeout
Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

My test collection with these fixes hasn't finished all architectures/jobs, but the x64 jobs completed and look good; I downloaded the collections, they're the right sizes, and I replayed successfully.

@BruceForstall
Copy link
Member Author

cc @dotnet/jit-contrib

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit 7752313 into dotnet:main Oct 14, 2021
@BruceForstall BruceForstall deleted the FixSpmiCollectionPipeline branch October 14, 2021 23:33
@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants