Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maui Android Size on Disk Integration #60425

Merged
merged 86 commits into from
Oct 19, 2021

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Oct 14, 2021

Integrates basic pipeline for Maui Scenarios. Checks off first goal of dotnet/performance#2075.
This included the addition of a yml file to get everything necessary setup to build Maui with the latest runtime data and make it available for testing the runtime repo.

…flag to set it to false since it may be part of why we are getting these weird errors.
… and build, added potential xcode work around, added an android specific build.
Added the android mono build and run to the testing pipeline.
Updated the artifact uploaded to only be the produced APK.
Added the downloading of the Maui APK to the perf-job for AndroidMono.
Added copying of the apk into the payload in performance-setup.ps1.
Added a helix workitem to 'run' the SOD tests for the Maui Android App, currently does simple testing things to make sure we have what we need.
@LoopedBard3 LoopedBard3 requested a review from billwert October 14, 2021 20:11
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@billwert billwert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 merged commit ed91cea into dotnet:main Oct 19, 2021
@jkotas
Copy link
Member

jkotas commented Oct 22, 2021

@LoopedBard3 Could you please move the top level maui directory to be under src/tests/sizeondisk in your next PR?

It is confusing to have top-level maui directory given the directory structure of this repo.

@jkotas
Copy link
Member

jkotas commented Oct 22, 2021

Or under src/tests/Common if it is meant to be used for more than just size on disk tests.

@LoopedBard3
Copy link
Member Author

Will do!

@LoopedBard3 LoopedBard3 deleted the MauiIntergrationTesting branch October 22, 2021 20:53
@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants