Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.Numerics.Vectors tests on iOS and other FullAOT targets #60335

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

akoeplinger
Copy link
Member

Instead of using dynamic we can use explicit type checks which don't require runtime code generation.
Also fixed running just a subset of xunit tests on Apple targets in tests.mobile.targets.

Instead of using dynamic we can use explicit type checks which don't require runtime code generation.
Also fixed running just a subset of xunit tests on Apple targets in tests.mobile.targets.
@akoeplinger akoeplinger added the os-ios Apple iOS label Oct 13, 2021
@akoeplinger akoeplinger requested a review from steveisok October 13, 2021 12:25
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Oct 13, 2021

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead of using dynamic we can use explicit type checks which don't require runtime code generation.
Also fixed running just a subset of xunit tests on Apple targets in tests.mobile.targets.

Author: akoeplinger
Assignees: -
Labels:

area-System.Numerics, os-ios

Milestone: -

@danmoseley
Copy link
Member

This seems like it would be a great place to use the new generic math feature? @tannergooding

@tannergooding
Copy link
Member

@danmoseley, yes, but it may also require more extensive changes to everything to allow it to work.

Probably worth an up-for-grabs work item.

@akoeplinger
Copy link
Member Author

Had to disable a few tests on Android x86 since they triggered a runtime assert: #60347

@akoeplinger akoeplinger merged commit 51c16ae into dotnet:main Oct 13, 2021
@akoeplinger akoeplinger deleted the fix-numerics-vectors-ios branch October 13, 2021 20:01
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants