-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runtime-staging trigger and one bug #60257
Conversation
We were triggering the runtime-staging jobs for all branches rather than just PRs and the scheduled runs on main. Fix it to only run for pushes on release branches, like runtime.yml. I also noticed a small bug where we had `interpreter: true` in the "iOS/tvOS devices - Full AOT + AggressiveTrimming" job, that was probably a copy/paste mistake.
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsWe were triggering the runtime-staging jobs for all branches rather than just PRs and the scheduled runs on main. I also noticed a small bug where we had
|
Hmm the Fuzzlyin pipeline also runs on every PR, presumably because of #59657. Would you mind also taking care of it? |
@ViktorHofer it's not running on every PR, just this one because I pushed a branch to the dotnet/runtime repo and not my fork and it is missing the |
Actually, is that pipeline supposed to be running on-demand via a comment trigger on PRs only? In that case we need to change an AzDO setting. |
This pipeline is still in progress ...I will disable it for now. Sorry for the confusion. |
@kunalspathak with the current settings it should only be triggered via an explicit |
We were triggering the runtime-staging jobs for all branches rather than just PRs and the scheduled runs on main.
Fix it to only run for pushes on release branches, like runtime.yml.
I also noticed a small bug where we had
interpreter: true
in the "iOS/tvOS devices - Full AOT + AggressiveTrimming" job, that was probably a copy/paste mistake.