Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime-staging trigger and one bug #60257

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

akoeplinger
Copy link
Member

We were triggering the runtime-staging jobs for all branches rather than just PRs and the scheduled runs on main.
Fix it to only run for pushes on release branches, like runtime.yml.

I also noticed a small bug where we had interpreter: true in the "iOS/tvOS devices - Full AOT + AggressiveTrimming" job, that was probably a copy/paste mistake.

We were triggering the runtime-staging jobs for all branches rather than just PRs and the scheduled runs on main.
Fix it to only run for pushes on release branches, like runtime.yml.

I also noticed a small bug where we had `interpreter: true` in the "iOS/tvOS devices - Full AOT + AggressiveTrimming" job, that was probably a copy/paste mistake.
@ghost
Copy link

ghost commented Oct 11, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

We were triggering the runtime-staging jobs for all branches rather than just PRs and the scheduled runs on main.
Fix it to only run for pushes on release branches, like runtime.yml.

I also noticed a small bug where we had interpreter: true in the "iOS/tvOS devices - Full AOT + AggressiveTrimming" job, that was probably a copy/paste mistake.

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

Hmm the Fuzzlyin pipeline also runs on every PR, presumably because of #59657. Would you mind also taking care of it?

@kunalspathak

@akoeplinger
Copy link
Member Author

@ViktorHofer it's not running on every PR, just this one because I pushed a branch to the dotnet/runtime repo and not my fork and it is missing the trigger key too, like runtime-staging. Will fix.

@akoeplinger
Copy link
Member Author

akoeplinger commented Oct 11, 2021

Actually, is that pipeline supposed to be running on-demand via a comment trigger on PRs only? In that case we need to change an AzDO setting.

@akoeplinger
Copy link
Member Author

I set the "Require a team member's comment" setting in AzDO for the Fuzzlyn pipeline:

image

@kunalspathak
Copy link
Member

This pipeline is still in progress ...I will disable it for now. Sorry for the confusion.

@akoeplinger
Copy link
Member Author

akoeplinger commented Oct 11, 2021

@kunalspathak with the current settings it should only be triggered via an explicit /azp run command so no need to explicitly disable it :)

@akoeplinger akoeplinger merged commit 4b84451 into main Oct 11, 2021
@akoeplinger akoeplinger deleted the alkpli/fix-runtime-staging branch October 11, 2021 22:56
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants