Fix inconsistencies in order of GeneratedDllImport fields #60049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Oct 6, 2021
|
We should update our code-fix to generate the properties in the order that matches this do we stay consistent. |
|
(And, very low priority, consider a style analyzer that suggests an ordering, ala https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0036) |
AaronRobinsonMSFT
approved these changes
Oct 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most common ordering I saw for existing
DllImports based on some simple regex searches wasEntryPointand then remaining ones in alphabetical order, so I went with that.cc @AaronRobinsonMSFT @jkoritzinsky