-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISMETHOD and ISMETHODHASH macros #59993
Conversation
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis PR adds if (ISMETHOD("Main"))
{
; // break or some printf when JIT compiles "Main" function
} Same for @dotnet/jit-contrib @SingleAccretion do you find it useful? Also, this PR changes types for
|
Co-authored-by: Andy Ayers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are intended to be used only when you are actively working on an issue and writing custom debugging code, right? So you would never expect to check in code that uses them?
It seems like you should add comments to that effect. In fact, maybe you should check these in commented out, and anyone who wants to use them can uncomment them at the same time as writing code to use them?
Changed to be available only in DEBUG/CHECKED and it won't compile in Release so nobody will be able to check it in |
This PR adds
ISMETHOD
andISMETHODHASH
macros so one can do something like:Same for
ISMETHODHASH(424242)
which is useful when one debugs superpmi failures@dotnet/jit-contrib @SingleAccretion do you find it useful? I personally write such strcmp quite often 🙂
Also, this PR changes types for
gtCallType
andgtReturnType
to corresponding enums for better intellisense (enums have the same underlying type - unsigned char)