[mono] Implement coreclr_create_delegate and move ComponentActivator to shared CoreLib #59962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
imhameed,
SamMonoRT and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
requested review from
jkoritzinsky,
steveisok,
vitek-karas and
AaronRobinsonMSFT
lambdageek
commented
Oct 4, 2021
Comment on lines
+355
to
+358
| gpointer addr = mono_compile_method_checked (wrapper, error); | ||
| goto_if_nok (error, fail); | ||
|
|
||
| *delegate = addr; |
There was a problem hiding this comment.
@vargaz I'm not sure if need to call mono_get_addr_from_ftnptr here or not.
lambdageek
force-pushed
the
component-activator-in-mono
branch
from
427bd72 to
25f55a7
Compare
lambdageek
commented
Oct 4, 2021
Should make ComponentActivator work without them
lambdageek
force-pushed
the
component-activator-in-mono
branch
from
9ff16db to
0ee0d0a
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreclr_create_delegatehosting API for MonoVMComponentActivatorinternal classes to the shared CoreLib areaContributes to #59815
Tested with https://github.com/lambdageek/dnne_monovm_sample