Fix IDE0008 in DllImportGenerator and Microsoft.Interop.SourceGeneration #59885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Oct 2, 2021
|
@stephentoub we have this set globally to 'silent' .. are we a long way from being able to enable it? |
AaronRobinsonMSFT
approved these changes
Oct 2, 2021
stephentoub
reviewed
Oct 3, 2021
...Runtime.InteropServices/gen/DllImportGenerator/Analyzers/ConvertToGeneratedDllImportFixer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
...Runtime.InteropServices/gen/DllImportGenerator/Analyzers/ConvertToGeneratedDllImportFixer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
...Runtime.InteropServices/gen/DllImportGenerator/Analyzers/ConvertToGeneratedDllImportFixer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
...ystem.Runtime.InteropServices/gen/DllImportGenerator/Analyzers/GeneratedDllImportAnalyzer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
...ystem.Runtime.InteropServices/gen/DllImportGenerator/Analyzers/GeneratedDllImportAnalyzer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
...em.Runtime.InteropServices/gen/DllImportGenerator/Analyzers/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
...em.Runtime.InteropServices/gen/DllImportGenerator/Analyzers/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
src/libraries/System.Runtime.InteropServices/gen/DllImportGenerator/DllImportGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
src/libraries/System.Runtime.InteropServices/gen/DllImportGenerator/DllImportGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
src/libraries/System.Runtime.InteropServices/gen/DllImportGenerator/DllImportGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 3, 2021
src/libraries/System.Runtime.InteropServices/gen/DllImportGenerator/DllImportGenerator.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
IDE0008: Use explicit type instead of 'var'This should be last of the style violation fixes in
DllImportGeneratorandMicrosoft.Interop.SourceGenerationsource (did not do tests).cc @AaronRobinsonMSFT @jkoritzinsky