-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test sensitivity to PKCS7 certificate ordering #59818
Conversation
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsAndroid exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first. Fixes #59777. After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsAndroid exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first. Fixes #59777. After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsAndroid exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first. Fixes #59777. After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.
|
Quietly files an internal bug ticket. |
My initial thought was "is it just reversed? can we just feed them in in a different order on Android?", but a few more seconds thought makes me guess that our other platforms end up sorting the certs by size as part of a DER SET OF ordering, and that Android is probably just taking them in the order presented. If it's the DER sort thing, then only like 20 people on the planet can reason about it, so it's not worth "normalizing" the Android behavior. |
CMS/PKCS#7 as a specification talks a lot about BER, and only requires DER where canonical encoding is required, liked |
Android exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first.
Fixes #59777.
After this PR and #59812 is merged, the X509Certificates test suite back to fully passing on Android.