Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Fix debugger after ts changes #59702

Merged
merged 6 commits into from
Sep 29, 2021
Merged

[wasm][debugger] Fix debugger after ts changes #59702

merged 6 commits into from
Sep 29, 2021

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Sep 28, 2021

Debugger was broken after #59392

  • The function name mono_wasm_fire_debugger_agent_message doesn't have the _ anymore
  • Reverting usage of local_eval, using local_eval will make eval run on global context, but we need proxy variable that is on local context.

@ghost
Copy link

ghost commented Sep 28, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Debugger was broken after #59392

  • The function name mono_wasm_fire_debugger_agent_message doesn't have the _ anymore
  • Reverting usage of local_eval, using local_eval will make eval run on global context, but we need proxy variable that is on local context.
Author: thaystg
Assignees: -
Labels:

area-Debugger-mono
Milestone: -

@thaystg thaystg added the arch-wasm WebAssembly architecture label Sep 28, 2021
@ghost
Copy link

ghost commented Sep 28, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Debugger was broken after #59392

  • The function name mono_wasm_fire_debugger_agent_message doesn't have the _ anymore
  • Reverting usage of local_eval, using local_eval will make eval run on global context, but we need proxy variable that is on local context.
Author: thaystg
Assignees: -
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@lewing lewing requested a review from kg September 28, 2021 16:19
@thaystg thaystg merged commit 9a03f0f into dotnet:main Sep 29, 2021
@thaystg thaystg deleted the fix_debugger_tests branch September 30, 2021 04:42
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg left review comments

@lambdageek lambdageek lambdageek approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thaystg @radical @kg @pavelsavara @lambdageek