[mono] Disable partial generic sharing for gparams with non-enum constraints. #59437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
imhameed,
lambdageek and
SamMonoRT
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
imhameed
approved these changes
Sep 23, 2021
|
@vargaz failures look potentially related |
vargaz
force-pushed
the
gshared-enum-constraint
branch
from
87da8e3
to
61375c4
Compare
vargaz
added
the
NO-MERGE
vargaz
force-pushed
the
gshared-enum-constraint
branch
from
61375c4
to
7711006
Compare
…traints. If a generic argument is a primitive type, and it has an interface constraint that enums don't implement, then partial sharing for that instance is not useful, since only the specific primitive type instance will be able to use the shared version. Fixes dotnet#54910.
vargaz
force-pushed
the
gshared-enum-constraint
branch
from
7711006
to
ab8e992
Compare
vargaz
removed
the
NO-MERGE
|
There are no more failures, either they got fixed, or the failing lane was disabled: |
|
cc @steveisok for test data |
|
We should merge and let the runtime tests run on the rolling build. |
steveisok
approved these changes
Nov 14, 2021
This is because tests are disabled, opened: #61564. :) |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.