-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] introduce typescript modules #59392
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
251960c
to
7804b0c
Compare
5e4995c
to
0b138df
Compare
5fea791
to
aed1e98
Compare
Would this make it possible to make runtime/src/mono/wasm/wasm.proj Line 10 in 4d41173
WasmEnableES6 results in importable ES6 module for dotnet in deno environment. It's also compatible in browser (since WASM and ES6 are mutually supported everywhere).
|
769d659
to
bd26b7d
Compare
I would love to, but I need to work thru all the consequences. Our unit test infrastructure and also the way how external projects like ASP.NET/Blazor consume us. So most likely it would not be in this PR. But it's on my wish list too. |
- use nodeJs from EMSDK - use rollup.js for packing code as ES6 IFFE for emcc consumption - incremental build Co-authored-by: Radek Doulik <[email protected]> - types Co-authored-by: Daniel Genkin <[email protected]>
bd26b7d
to
9e8eb7e
Compare
OSX failure is unrelated timeout. |
@radical I introduced new file to AOT inputs. I don't know how it would impact VS/workloads. We will probably remove or rename all the other |
cc @Thays to try this with the debugger tests. |
Goals
Introduce typescript and break up the code to multiple, better encapsulated modules.
runtime.iffe.js
is compiled with emcc and AOT as--pre-js
package.json
references explicit versions of dev-time only dependencies. They are not necessary on link time.npm ci
in CI pipeline to make sure we get exactly same version as in lock file.npm audit
in CI so that we are sure we don't have new security issue in the CI.ignore_pdb_load_errors
is nowModule.config
optionNon-goals
library_mono.js
, the rest will be in follow up PRs