-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rocky Linux support #59178
Rocky Linux support #59178
Conversation
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsAdd Rocky Linux support Changes based on those necessary for Rocky Linux downstream rebuild of RHEL source packages for dotnet 3.1 and dotnet 5.0.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
<RuntimeGroup Include="rocky"> | ||
<Parent>rhel</Parent> | ||
<Architectures>x64;arm64</Architectures> | ||
<Versions>8;8.4;9</Versions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there significance to 8.4? Seems like the build is compelling the parent is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My experience with RHEL is that we really want to avoid adding minors here. There's going to be a Rocky/RHEL 8.x release every 6 months or so. (It's tiring enough on Fedora where there's a major bump every 6 months.) It was entirely unnecessary for RHEL 8.4, and I think we should do the same for Rocky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I wasn't entirely sure of the significance of including the minor version, either. I merged the original Rocky Linux patches and one had 8
and the other 8.4
, IIRC. If you see no reason to have the minor version listed, I can remove it from the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wfurt For compat, ideally, we should treat Rocky same way we treat CentOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any final thoughts @omajid ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Is there anything else necessary before this PR can be merged? Thanks! |
Add Rocky Linux support
Changes based on those necessary for Rocky Linux downstream rebuild of RHEL source packages for dotnet 3.1 and dotnet 5.0.