Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocky Linux support #59178

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Rocky Linux support #59178

merged 2 commits into from
Oct 5, 2021

Conversation

N3WWN
Copy link
Contributor

@N3WWN N3WWN commented Sep 15, 2021

Add Rocky Linux support

Changes based on those necessary for Rocky Linux downstream rebuild of RHEL source packages for dotnet 3.1 and dotnet 5.0.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 15, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Add Rocky Linux support

Changes based on those necessary for Rocky Linux downstream rebuild of RHEL source packages for dotnet 3.1 and dotnet 5.0.

Author: N3WWN
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Sep 15, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@josteink josteink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

<RuntimeGroup Include="rocky">
<Parent>rhel</Parent>
<Architectures>x64;arm64</Architectures>
<Versions>8;8.4;9</Versions>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there significance to 8.4? Seems like the build is compelling the parent is missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My experience with RHEL is that we really want to avoid adding minors here. There's going to be a Rocky/RHEL 8.x release every 6 months or so. (It's tiring enough on Fedora where there's a major bump every 6 months.) It was entirely unnecessary for RHEL 8.4, and I think we should do the same for Rocky.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I wasn't entirely sure of the significance of including the minor version, either. I merged the original Rocky Linux patches and one had 8 and the other 8.4, IIRC. If you see no reason to have the minor version listed, I can remove it from the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wfurt / @omajid FYI, I just removed the 8.4 from the PR

@wfurt
Copy link
Member

wfurt commented Sep 21, 2021

since Rocky claims binary compatibility with rhel, do we need to track it separately? (I'm not posing, just asking)

cc: @omajid @tmds

@omajid
Copy link
Member

omajid commented Sep 22, 2021

@wfurt For compat, ideally, we should treat Rocky same way we treat CentOS.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any final thoughts @omajid ?

Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@N3WWN
Copy link
Contributor Author

N3WWN commented Oct 5, 2021

Is there anything else necessary before this PR can be merged? Thanks!

@wfurt wfurt merged commit ec15b53 into dotnet:main Oct 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants