Add missing docs to System.Text.Json #59053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
added
documentation
eiriktsarpalis
requested review from
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsContributes to #54862.
|
danmoseley
approved these changes
Sep 13, 2021
carlossanlop
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
LGTM.
@eiriktsarpalis why didn't the build fail locally before? I thought the System.Text.Json assemblies enforced adding triple slash docs. Are the Nodes types in a different assembly? If they are, should their csproj enforce docs too?
Good question. Likely it wasn't enabled. I'll investigate. |
|
Test failures unrelated to docs changes, merging away. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #54862.