Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete test projects under src/tests/hosting #58304

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

elinor-fung
Copy link
Member

Under src/tests/hosting

  • coreclr/: only shared libraries that are never used, so we are just building/zipping/uploading them for fun
  • samples/: more shared libraries that are never used
  • stress/testset1/csgen.2: has an actual test project that appears to have been generated - I deleted it because it doesn't seem very useful and I didn't find any issues that were uncovered from it. (Also, I'm unclear how it is related to hosting)

cc @vitek-karas

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Aug 28, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Under src/tests/hosting

  • coreclr/: only shared libraries that are never used, so we are just building/zipping/uploading them for fun
  • samples/: more shared libraries that are never used
  • stress/testset1/csgen.2: has an actual test project that appears to have been generated - I deleted it because it doesn't seem very useful and I didn't find any issues that were uncovered from it. (Also, I'm unclear how it is related to hosting)

cc @vitek-karas

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

@elinor-fung elinor-fung added this to the 7.0.0 milestone Aug 28, 2021
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find a reason we should keep these either 😉

@elinor-fung elinor-fung merged commit 017b1c4 into dotnet:main Aug 30, 2021
@elinor-fung elinor-fung deleted the deleteTestProjects branch August 30, 2021 17:18
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants