-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't build ReferenceSystemPrivateCoreLib tests with Mono #58232
Don't build ReferenceSystemPrivateCoreLib tests with Mono #58232
Conversation
When building tests that reference System.Private.CoreLib, use the one from the specified RuntimeFlavor (or fall back to coreclr if it's unset - although src/tests/build.sh sets it always) This means we only need to build the Clr.Native subset if we're interested in testing Mono.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsWhen building tests that reference System.Private.CoreLib, use the one from the specified RuntimeFlavor (or fall back to coreclr if it's unset - although src/tests/build.sh sets it always) This means we only need to build the Clr.Native subset if we're interested in testing Mono.
|
Even better would be if there was a |
781bfe7
to
a46acb0
Compare
a46acb0
to
8b82790
Compare
Some tests depend on the intrenals of CoreCLR's System.Private.CoreLib (specifically Internal.Runtime.InteropServices). Don't build those tests when compiling against Mono's System.Private.CoreLib.
src/tests/Interop/COM/Activator/ActivatorBuiltInComDisabled.csproj
Outdated
Show resolved
Hide resolved
The typical workflow for working on a new corelib API is to add it to reference assembly under libraries and then you do not need to worry about referencing corelib from tests at all, and you can also write the tests under libraries that is the preferred place for API tests. I think we should be working on getting rid of the tests that reference CoreLib directly, no need to grow the hack. |
90a0ee1
to
1e354e0
Compare
👍 |
We should avoid adding new ReferenceSystemPrivateCoreLib tests
1e354e0
to
2f796d1
Compare
New tests that extend the System.Private.CoreLib API should add to the ref assemblies in src/libraries and the tests themselves should be library tests.
Updated the workflow doc: the Clr.Native subset is all that is need if we're interested in testing Mono.
Contributes to #58266