-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lateapexearlyspeed-issue-30778 Create method: TryReadExact(). #57921
lateapexearlyspeed-issue-30778 Create method: TryReadExact(). #57921
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @GrabYourPitchforks, @dotnet/area-system-buffers Issue DetailsFix #30778
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with 1 comment formatting suggestion. I'd like to get a secondary review from @tannergooding, @davidfowl, or @GrabYourPitchforks though.
src/libraries/System.Memory/src/System/Buffers/SequenceReader.Search.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Handley <[email protected]>
The implementation looks fine but I'm wondering if there's a more optimal implementation. Can we add benchmarks for this new method? |
Hi @davidfowl Sorry I am not very familiar with workflow of adding benchmark. Because it is new method, is that dotnet runtime repo publishes new pack then perf repo references that new dotnet pack so that it can build to get new method ? |
@lateapexearlyspeed The instructions are here: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md#benchmarking-workflow-for-dotnetruntime-repository Let us know if you have any trouble getting that set up. @davidfowl Any objections to merging this implementation as-is so long as we follow up with adding a new benchmark to dotnet/performance? Or do you want to see the (new, local) benchmark results before we merge? |
I'm fine merging it with the benchmark as a follow up |
Thanks for the contribution, @lateapexearlyspeed! #60332 was filed for creating the microbenchmarks. If you're interested in contributing the new benchmarks, please leave a comment on that issue and I can assign it to you. |
Fix #30778
Will change PR to normal status when it is ready for review, thanks.