Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle special error event #57804

Merged
merged 4 commits into from
Aug 24, 2021
Merged

handle special error event #57804

merged 4 commits into from
Aug 24, 2021

Conversation

FatTigerWang
Copy link
Contributor

handle special error event

  1. Handling ERROR_EVT_UNRESOLVED_PARAMETER_INSERT and ERROR_RESOURCE_TYPE_NOT_FOUND
  2. Remove an unnecessary judgment

Fix #56469

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 20, 2021
@runfoapp runfoapp bot mentioned this pull request Aug 20, 2021
Closed
@FatTigerWang FatTigerWang mentioned this pull request Aug 24, 2021
Closed
danmoseley
danmoseley approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @FatTigerWang !

@danmoseley danmoseley merged commit 2201bab into dotnet:main Aug 24, 2021
@danmoseley
Copy link
Member

@FatTigerWang welcome to the repo. is there any other change you'd be interested in contributing?
https://github.com/dotnet/runtime/issues?q=is%3Aissue+is%3Aopen+label%3Aup-for-grabs

@FatTigerWang FatTigerWang deleted the issue-56469-handle-ERROR_EVT branch August 25, 2021 02:39
@danmoseley danmoseley mentioned this pull request Sep 8, 2021
Open
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics.EventLog community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
2 participants
@FatTigerWang @danmoseley