-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend MemoryCacheOptions with TrackLinkedCacheEntries #57648
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @eerhardt, @maryamariyan, @michaelgsharp Issue Detailsfixes #45592
|
src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCacheOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCacheOptions.cs
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCache.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <[email protected]>
There is just one entry being created in this test (no dependencies to other linked entries) and it just verifies whether setting entry as expired is thread-safe (not related to tracking) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Failures are unrelated. Timing out due to dotnet/core-eng#14346 |
arm64 improvements: dotnet/perf-autofiling-issues#1537 |
To be honest I've not merged it because I wanted to check if something in ASP.NET repo is going to get broken with this change. It has been a month since it was merged and nobody started screaming. I guess it just proves that it was good idea to introduce the breaking change and disable the tracking by default. |
@adamsitnik someone finally screamed |
@adamsitnik were you planning to create a breaking change document for this? |
I just added dotnet/docs#31739 |
@maryamariyan big thanks for doing that! |
fixes #45592