Ignore IOException in PollingFileChangeToken

[jozkee]

Contributes to #57221, ignores the exception to unblock clean CI.
I've also split throw calls to one per stat/lstat to identify which is the one throwing EINVAL.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Contributes to #57221, ignores the exception to unblock clean CI.
I've also split throw calls to one per stat/lstat to identify which is the one throwing EINVAL.

Author:	Jozkee
Assignees:	Jozkee
Labels:	area-System.IO
Milestone:	6.0.0

[danmoseley]

this is fine (with fix I noted above) but I wonder whether it would be helpful (in another PR) to log the path for more exception types in GetExceptionForIoErrno. Right now although you pass the path it drops the path for several error codes, including the EINVAL in this case

runtime/src/libraries/Common/src/Interop/Unix/Interop.IOErrors.cs

Line 168 in e7b743c

return new IOException(errorInfo.GetErrorMessage(), errorInfo.RawErrno);

You could potentially improve that to include the path. It would mean adding a new string -- look for ArgumentOutOfRange_FileLengthTooBig to find the 11 resx files that would need it. The string would look like "Error accessing path '{0}'. {1}" and the code would be

    internal static Exception GetIOException(Interop.ErrorInfo errorInfo)
    {
                return path != null ?
                    new IOException(SR.Format(SR.IO_YourNewString, path, errorInfo.GetErrorMessage()), errorInfo.RawErrno) :
                    new IOException(errorInfo.GetErrorMessage(), errorInfo.RawErrno);
    }

I think that would be a reasonable product change that would also potentially help with this bug.

[danmoseley]

lgtm with the note

[danmoseley]

The tests are failing because somewhere we passed -1 to the constructor of ErrorInfo.

[jozkee]

The tests are failing because somewhere we passed -1 to the constructor of ErrorInfo.

Addressed in 6d09715.

[ghost]

Hello @jozkee!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.