Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Fix cancelling shutdown completion source #55993

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[QUIC] Fix cancelling shutdown completion source #55993

merged 1 commit into from
Jul 20, 2021

Conversation

CarnaViire
Copy link
Member

Fixes #55706

@ghost
Copy link

ghost commented Jul 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #55706

Author: CarnaViire
Assignees: -
Labels:

area-System.Net.Quic
Milestone: -

@CarnaViire CarnaViire mentioned this pull request Jul 20, 2021
Merged
wfurt
wfurt approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarnaViire CarnaViire merged commit f100379 into dotnet:main Jul 20, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

@ManickaP ManickaP ManickaP approved these changes

@geoffkizer geoffkizer Awaiting requested review from geoffkizer

Assignees
No one assigned
Labels
area-System.Net.Quic
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

QUIC: ShutdownCompleted cancellation token does not actually cancel the call
4 participants
@CarnaViire @ManickaP @wfurt @karelz