Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile-use-only mode for MultiCoreJit #55005

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

gbalykov
Copy link
Member

@gbalykov gbalykov commented Jul 1, 2021

  • memory consumption is reduced if profile is not gathered
  • disk/flash life is increased if profile is not saved each time

On Tizen both points are crucial, because devices have limited ram and use flash memory. Private_Dirty memory consumption of tizen xamarin apps is reduced on ~500 Kb with this change (is noprofilegather is set).

cc @alpencolt @kouvel

gbalykov added 2 commits July 16, 2021 19:52
- memory consumption is reduced if profile is not gathered
- disk/flash life is increased if profile is not saved each time
@gbalykov gbalykov force-pushed the add-mcj-no-profile-gather-mode branch from 2b55b55 to e06e952 Compare July 16, 2021 18:33
@gbalykov
Copy link
Member Author

@kouvel I've updated PR with your suggestions. Also, I've cleaned up unused m_fAppxMode.

Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, LGTM otherwise, thanks!

src/coreclr/vm/multicorejitimpl.h Show resolved Hide resolved
@gbalykov gbalykov force-pushed the add-mcj-no-profile-gather-mode branch from 5b49575 to 6a8e8e1 Compare July 19, 2021 16:56
@terrajobst terrajobst added the community-contribution Indicates that the PR has been added by a community member label Jul 19, 2021
@kouvel kouvel merged commit cbfa7cf into dotnet:main Jul 20, 2021
@gbalykov
Copy link
Member Author

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-TieredCompilation-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants