Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Reflection.Metadata readonly annotation #51813

Closed

Conversation

hrrrrustic
Copy link
Contributor

This PR is a part of #46675

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@hrrrrustic
Copy link
Contributor Author

NamespaceDefinition and SignatureHeader can be readonly struct
Blobs can be also, but


is actually mutating internally here
public bool MoveNext() => _chunks.MoveNext();
public void Reset() => _chunks.Reset();

@jeffhandley jeffhandley marked this pull request as draft April 29, 2021 20:48
@jeffhandley
Copy link
Member

This PR is being marked as a draft per #46675 (comment).

@ghost ghost closed this May 29, 2021
@ghost
Copy link

ghost commented May 29, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 28, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants