System.IO.Pipelines readonly annotation #51810
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
| @@ -88,7 +88,7 @@ public void Reset() | |||
| _state = null; | |||
There was a problem hiding this comment.
this assignment to _state means that readonly can't be used here.
There was a problem hiding this comment.
There is no readonly at Reset(). Github diff merged IsCompletedOrThrow() and Reset() :)
There was a problem hiding this comment.
Ah, my bad, unhelpful diff window size.
| private readonly CancellationToken CancellationToken => _cancellationTokenRegistration.Token; | ||
| #else | ||
| private CancellationToken _cancellationToken; | ||
| private CancellationToken CancellationToken => _cancellationToken; |
There was a problem hiding this comment.
If line 22 can be readonly can't 25 also be readonly? they're the same property in different builds.
|
This PR is being marked as a draft per #46675 (comment). |
ghost
closed this
|
Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This PR is a part of #46675