Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Memory readonly annotation #51805

Closed
wants to merge 2 commits into from
Closed

System.Memory readonly annotation #51805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42ffb14
readonly annotation
hrrrrustic Apr 12, 2021
c52e884
fix missed marking, remove auto getter marking
hrrrrustic Apr 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Memory/ref/System.Memory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,8 @@ public ref partial struct SpanRuneEnumerator
{
private object _dummy;
private int _dummyPrimitive;
public System.Text.Rune Current { get { throw null; } }
public System.Text.SpanRuneEnumerator GetEnumerator() { throw null; }
public readonly System.Text.Rune Current { get { throw null; } }
public readonly System.Text.SpanRuneEnumerator GetEnumerator() { throw null; }
public bool MoveNext() { throw null; }
}
}
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Text/SpanRuneEnumerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ internal SpanRuneEnumerator(ReadOnlySpan<char> buffer)
_current = default;
}

public Rune Current => _current;
public readonly Rune Current => _current;

public SpanRuneEnumerator GetEnumerator() => this;
public readonly SpanRuneEnumerator GetEnumerator() => this;

public bool MoveNext()
{
Expand Down