NameResolution-Tests: enable GetHostEntryAsync_InvalidHost_LogsError on Windows #47034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIn #34633 (comment) a product bug in regards of logging was found. On local testing I couldn't spot any unrealiable behavior, per #34633 (comment) we should give this a try to see what happens.
|
stephentoub
reviewed
Jan 15, 2021
src/libraries/System.Net.NameResolution/tests/FunctionalTests/LoggingTest.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34633 (comment) a product bug in regards of logging was found.
This didn't show up in tests, as it was disabled for Windows
runtime/src/libraries/System.Net.NameResolution/tests/FunctionalTests/LoggingTest.cs
Line 66 in 911b1d3
On local testing I couldn't spot any unrealiable behavior, per #34633 (comment) we should give this a try to see what happens.
Edit: Fixes #47104