-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new net6.0 TargetFramework #42709
Conversation
Anipik
commented
Sep 24, 2020
- adding a new target framework net6.0
- making coreclr tool target net5.0
- make packages containing net5.0 exclude netcoreappcurrent
src/coreclr/src/tools/Common/JitInterface/ThunkGenerator/ThunkGenerator.csproj
Outdated
Show resolved
Hide resolved
src/coreclr/src/tools/Common/JitInterface/ThunkGenerator/ThunkGenerator.csproj
Outdated
Show resolved
Hide resolved
Can you please verify if vstest still works? I believe the xunit.visualstudio package and vstest were hardcoding on checking for "net5.0" of "netcoreapp". cc @nohwnd |
@ViktorHofer yes, it should work. The change that caused that problem was rolled back somewhere between Preview8 and 5.0.100-rc.1.20451.10. |
src/installer/tests/Assets/TestProjects/HammerServiceApp/Location/Location.csproj
Outdated
Show resolved
Hide resolved
src/installer/tests/Assets/TestProjects/TestWindowsOsShimsApp/TestWindowsOsShimsApp.csproj
Outdated
Show resolved
Hide resolved
@marek-safar @akoeplinger can you help with the browser errors here ? i m not aware how everything is put together. |
@ViktorHofer @ericstj @safern this one is complete, can you please take a look ? |
src/mono/wasm/debugger/BrowserDebugHost/BrowserDebugHost.csproj
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/BrowserDebugProxy.csproj
Outdated
Show resolved
Hide resolved
<NuGetTargetMoniker>$(NetCoreAppCurrentToolTargetFrameworkMoniker)</NuGetTargetMoniker> | ||
<NuGetTargetMonikerShort>$(NetCoreAppToolCurrent)</NuGetTargetMonikerShort> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/libraries/System.Net.Http.Json/src/System.Net.Http.Json.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍👍
@Anipik before merging, please validate if building and testing inside Visual Studio still works. Also please validate that |
src/libraries/System.Security.Permissions/ref/System.Security.Permissions.csproj
Outdated
Show resolved
Hide resolved
|
Merging the change as failure is known and we have a tracking issue. |
Note that this is a breaking change which ideally would go trough a monthly rollout. Please send out a mail to the team explaining why this was merged now and what the breaking change is about. |