Enable several more IDE analyzer warnings #42692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
danmoseley
reviewed
Sep 24, 2020
src/coreclr/src/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Show resolved
Hide resolved
danmoseley
reviewed
Sep 24, 2020
src/libraries/System.Private.CoreLib/src/System/Runtime/Serialization/SerializationInfo.cs
Show resolved
Hide resolved
danmoseley
reviewed
Sep 24, 2020
src/libraries/System.Private.CoreLib/src/System/Runtime/Serialization/SerializationInfo.cs
Show resolved
Hide resolved
danmoseley
reviewed
Sep 24, 2020
danmoseley
approved these changes
Sep 24, 2020
stephentoub
force-pushed
the
morewarnings
branch
from
35f5260 to
02917dd
Compare
safern
approved these changes
Sep 24, 2020
This was referenced Oct 22, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable IDE0062: Make local functions static
Enable IDE0079: Remove unnecessary suppression
Enable IDE0082: Convert typeof to nameof
Enable IDE0043: Validate format string
Enable IDE0041: Use is null check
cc: @safern, @ViktorHofer