Microsoft.Extensions.Internal.Transport and System.Numerics.tensors are not stable shipping packages #41632
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
non shipping folder |
|
This is approved for 5.0 as it is ensuring we ship the correct bits. |
| <!-- This is a preview package. Do not mark as stable. --> | ||
| <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion> | ||
| <IsShippingAssembly>false</IsShippingAssembly> | ||
| <IsShipping>false</IsShipping> |
There was a problem hiding this comment.
This is wrong. As System.Numerics.Tensors is a shipping package but with a non-stable version.
There was a problem hiding this comment.
Which means it won't make it to nuget.org anymore. I believe we want that to go to nuget.org. I asked this a while ago.
#33636 (comment)
There was a problem hiding this comment.
I believe you want to do:
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
instead
There was a problem hiding this comment.
Just as we had it. We shouldn't change this package at all. We need IsShippingAssembly=false so that the assembly metadata contains the non-stable version.
There was a problem hiding this comment.
We dont want to ship any rc or rtm versions of these packages. (as we did in 3.1)
There was a problem hiding this comment.
adding <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
will still ship the rc1 & rc2 version and we dont want that as well.
There was a problem hiding this comment.
Ok... why not instead exclude them from the build list in libraries-packages.proj and don't build them at all?
There was a problem hiding this comment.
We need to build Microsoft.Extensions.Internal.Transport as it is necessary for aspnetcore.
For System.Numerics.Tensors we just want the smallest change to not produce the shipping package. As mentioned in the issue we'll remove this code completely in 6.0 and put it back in corefxlab.
|
@Anipik is there a master PR that adds the |
yeah it should be ported to master as well. i will do that. |
ghost
locked as resolved and limited conversation to collaborators
Fixes #41560