Mdhwang/reduce mobile checks #35105
Merged
Mdhwang/reduce mobile checks #35105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
ViktorHofer
reviewed
Apr 17, 2020
mdh1418
force-pushed
the
mdhwang/reduce_mobile_checks
branch
from
2d22e09 to
34fe1b7
Compare
ViktorHofer
approved these changes
Apr 17, 2020
2 tasks
safern
reviewed
Apr 17, 2020
safern
reviewed
Apr 17, 2020
src/installer/pkg/projects/netcoreapp/pkg/Microsoft.NETCore.App.Runtime.pkgproj
Outdated
Show resolved
Hide resolved
safern
reviewed
Apr 17, 2020
|
If PR: #34980 is merged first, maybe consider removing these: https://github.com/dotnet/runtime/pull/34980/files#diff-9f3c793773fc53c31ea09d056e98a4eeR200 as I believe |
mdh1418
force-pushed
the
mdhwang/reduce_mobile_checks
branch
from
34fe1b7 to
641bdbb
Compare
mdh1418
force-pushed
the
mdhwang/reduce_mobile_checks
branch
from
641bdbb to
c6f2c9a
Compare
mdh1418
commented
Apr 20, 2020
mdh1418
force-pushed
the
mdhwang/reduce_mobile_checks
branch
from
c6f2c9a to
1b24994
Compare
This was referenced Apr 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR #34662.
This PR simplifies conditional checks
'$(TargetOS)' == 'iOS' or '$(TargetOS)' == 'Android' or '$(TargetOS)' == 'tvOS'and all other permutations with'$(TargetsMobile)' == 'true'#35023