Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix which platform should be excluded. #1314

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix which platform should be excluded. #1314

merged 1 commit into from
Jan 6, 2020

Conversation

sandreenko
Copy link
Contributor

Fix the error from #1283.

Thanks @jashook for catching this.

@jkotas
Copy link
Member

jkotas commented Jan 6, 2020

Without this change, the PRs are failing with:

Pipeline configuration error:
Job run_test_p0__Linux_arm_checked depends on unknown job coreclr_test_build_p0_Linux_arm_checked.

@sandreenko sandreenko merged commit be5f4d7 into dotnet:master Jan 6, 2020
@sandreenko
Copy link
Contributor Author

Merge before the testing is finished to unblock ci.

jashook
jashook reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@jashook jashook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sandreenko sandreenko deleted the fixTypoFromPrevPR branch January 6, 2020 04:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jashook jashook jashook left review comments

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandreenko @jkotas @jashook