Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing jobs in PR testing. #1283

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Disable failing jobs in PR testing. #1283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c193d
Disable failing jobs in PR testing.
Jan 3, 2020
8211f08
Disable the same in runtime file.
Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/coreclr/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
- Linux_musl_x64
- Linux_x64
- OSX_x64
- Windows_NT_arm
# - Windows_NT_arm return this when https://github.com/dotnet/runtime/issues/1097 is fixed.
- Windows_NT_arm64
- Windows_NT_x64
- Windows_NT_x86
Expand Down Expand Up @@ -171,7 +171,7 @@ jobs:
jobTemplate: /eng/pipelines/coreclr/templates/crossgen-comparison-job.yml
buildConfig: checked
platforms:
- Linux_arm
# - Linux_arm Return this when https://github.com/dotnet/runtime/issues/1282 is fixed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest increasing the timeout, instead of disabling the submission entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

helixQueueGroup: pr
helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml
jobParameters:
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
platforms:
- OSX_x64
- Linux_x64
- Linux_arm
# - Linux_arm return this when https://github.com/dotnet/runtime/issues/1097 is fixed.
Copy link
Contributor

@jashook jashook Jan 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this commented out. The comment beside it seems to be for Windows am but this is Linux arm

- Windows_NT_x86
- Windows_NT_x64
- Windows_NT_arm
Expand Down