Set the ReferenceAssembly metadata on the manually added ReferencePath items #109433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h items Unblocks using runtime with a newer arcade that actually respects Roslyn ref assemblies.
jkoritzinsky
added
blocking
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
hoyosjs
approved these changes
Oct 31, 2024
| @@ -17,6 +17,7 @@ | |||
| <Target Name="AddFrameworkFilesToPackage" DependsOnTargets="ResolveLibrariesFromLocalBuild" BeforeTargets="GetFilesToPackage"> | |||
| <ItemGroup> | |||
| <ReferencePath Include="@(LibrariesRefAssemblies)" /> | |||
| <ReferencePath ReferenceAssembly="%(Identity)" /> | |||
There was a problem hiding this comment.
This is used in the SharedFramework SDK now (as of the arcade update PR that's currently in flight) to select the (usually Roslyn-produced) ref assembly instead of the implementation assembly when building a ref pack.
There was a problem hiding this comment.
This was changed in dotnet/arcade#15209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks using runtime with a newer arcade that actually respects Roslyn ref assemblies.
Needed to unblock the dotnet/sdk VMR build.