Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding info to debug WindowsAlternateDataStreamOverwrite failure #109399

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

PranavSenthilnathan
Copy link
Member

@PranavSenthilnathan PranavSenthilnathan commented Oct 31, 2024

Adding info for: #83659

  • Adding assertion on HRESULT in the non-overwrite case to confirm that it does not have the same issue as the WindowsAlternateDataStreamOverwrite
  • Adding logging of attributes
  • Assertion on contents of files to determine whether everything is written/accessible before copy

I wasn't able to repro this after trying to run nativeaot build on arm64. Confirmed that it wasn't FAT32 issue (tried mounting volume and it gives a different error) and that the tests were running nativeaot (checked PlatformDetection.IsNativeAot). Hopefully adding the above will give some more info next time this fails.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good idea to log more info, I am just not sure if the current implementation is going to work.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @PranavSenthilnathan ! If possible please merge it at the beginning of your work day and take a look at the CI in a few hours, just to ensure the changes have not made the CI flaky.

@PranavSenthilnathan PranavSenthilnathan merged commit 4362771 into dotnet:main Nov 4, 2024
81 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants