Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Switch to non-incremental servicing #109316

Merged

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Oct 28, 2024

Customer impact

For .NET 9 and all future versions, we are switching to non-incremental servicing by removing the need to manually bump the package versions every time a change is made in an OOB assembly like we used to do in .NET 8 and older versions.

Regression

No. This is an intended behavior for servicing starting with .NET 9.

Testing

We verified the correct behavior of these changes during the release + servicing readiness exercise.

Risk

Low. These changes are not affecting product behavior, but the way we increment package versioning in servicing

carlossanlop and others added 2 commits October 28, 2024 13:23
- Remove incremental servicing docs.
- Update APICompat baseline.
- Remove some mentions of package servicing process.
- Remove redundant source build setting of GeneratePackageOnBuild.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member Author

First Responders has reported that the CI is not actively getting triggered in PRs since early morning Monday 28th and the issue is being investigated. We need to monitor the Teams chat group for an update so we can close + reopen this PR after the issue is fixed.

@ViktorHofer
Copy link
Member

/backport to main

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/11707855525

Copy link
Contributor

github-actions bot commented Nov 6, 2024

@ViktorHofer backporting to main failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Change pre-release version label to servicing. Bump patch version to 1.
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Change pre-release version label to servicing. Bump patch version to 1.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

github-actions bot commented Nov 6, 2024

@ViktorHofer an error occurred while backporting to main, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@carlossanlop
Copy link
Member Author

carlossanlop commented Nov 6, 2024

The build failure looks related

dotnet\sdk\9.0.100-rc.2.24474.11\Microsoft.Common.CurrentVersion.targets(2413,5): error MSB3277: Found conflicts between different versions of "System.Diagnostics.DiagnosticSource" that could not be resolved. There was a conflict between "System.Diagnostics.DiagnosticSource, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" and "System.Diagnostics.DiagnosticSource, Version=9.0.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51". "System.Diagnostics.DiagnosticSource, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" was chosen because it was primary and "System.Diagnostics.DiagnosticSource, Version=9.0.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" was not. References which depend on "System.Diagnostics.DiagnosticSource, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" [D:\a\_work\1\s\artifacts\bin\System.Diagnostics.DiagnosticSource\ref\Release\net462\System.Diagnostics.DiagnosticSource.dll]. D:\a\_work

Edit: Fixed

@carlossanlop
Copy link
Member Author

/ba-g All failures have been linked to issues

@carlossanlop carlossanlop merged commit 824bdd2 into dotnet:release/9.0-staging Nov 13, 2024
155 of 160 checks passed
@carlossanlop carlossanlop deleted the NonIncrementalServicing branch November 13, 2024 17:59
@carlossanlop
Copy link
Member Author

@ViktorHofer don't know if you noticed but the backport to main failed. Would you like me to take care of creating the equivalent main PR or are you doing that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants